Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for visual selection actions #9

Conversation

KostkaBrukowa
Copy link
Contributor

Hey!
I've found out that visual selection code actions doesn't work so I've just copied some code from core

@luckasRanarison
Copy link
Owner

luckasRanarison commented Oct 6, 2023

Thanks for the PR! I didn't add visual mode because I couldn't find actual use cases but this looks good to me. Do you think we should also add some additional props to the mappings or enable visual keymaps by default?

@KostkaBrukowa
Copy link
Contributor Author

I'm mainly working in typescript and those actions:
image
are really useful for me :D
About the props, I'm using it like this

vim.keymap.set({ "n", "v" }, "<C-.>", require("clear-action").code_action, { silent = true })

and it automatically detect in which mode I'm, so I don't think any props are necessary in this case

@luckasRanarison luckasRanarison merged commit 42fc589 into luckasRanarison:master Oct 6, 2023
@luckasRanarison
Copy link
Owner

I've added visual mode keymaps by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants