This repository has been archived by the owner on May 16, 2024. It is now read-only.
improved splitting: sort entries #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lua/nvim-devdocs/build.lua
Outdated
| end | ||
|
|
||
| path_map[key] = tostring(count) | ||
| file_path:write(markdown, "w") | ||
| count = count + 1 | ||
| end | ||
|
|
||
| table.sort(index.entries, function(a, b) | ||
| local index_a = sort_lookup[a.path] |
There was a problem hiding this comment.
Suggested change
| local index_a = sort_lookup[a.path] | |
| local index_a = sort_lookup[a.path] or -1 |
lua/nvim-devdocs/build.lua
Outdated
| end | ||
|
|
||
| path_map[key] = tostring(count) | ||
| file_path:write(markdown, "w") | ||
| count = count + 1 | ||
| end | ||
|
|
||
| table.sort(index.entries, function(a, b) | ||
| local index_a = sort_lookup[a.path] | ||
| local index_b = sort_lookup[b.path] |
There was a problem hiding this comment.
Suggested change
| local index_b = sort_lookup[b.path] | |
| local index_b = sort_lookup[b.path] or -1 |
lua/nvim-devdocs/operations.lua
Outdated
| local split = vim.split(pattern, " ") | ||
| local header = split[1] | ||
| local top_header = header and header:sub(1, #header - 1) | ||
| local next_pattern_lines = vim.split(next_pattern, "\n") |
There was a problem hiding this comment.
next_pattern could be nil
lua/nvim-devdocs/operations.lua
Outdated
| local header = split[1] | ||
| local top_header = header and header:sub(1, #header - 1) | ||
| local next_pattern_lines = vim.split(next_pattern, "\n") | ||
| local next_search_pattern = create_pattern(next_pattern_lines[1]) -- only search the first line | ||
|
|
||
| for _, line in ipairs(lines) do | ||
| if found then |
|
I now applied the review comments in a followup commit! |
|
Thanks! It's also backward compatible :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #57
this seems to work well according to my testing.