Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show github heading for mit license #1400

Merged
merged 5 commits into from Jan 28, 2019
Merged

show github heading for mit license #1400

merged 5 commits into from Jan 28, 2019

Conversation

untuned
Copy link
Contributor

@untuned untuned commented Jan 26, 2019

just a cosmetic change, shows above the file

@lucko
Copy link
Member

lucko commented Jan 28, 2019

The issue is that there's also a HEADER.txt file which contains license text.

Even though this is the same underlying licence, the code used by GitHub to detect licenses sees this as being ambiguous.

I did think about reporting it here: https://github.com/benbalter/licensee

@lucko lucko merged commit 22252fa into LuckPerms:master Jan 28, 2019
@lucko
Copy link
Member

lucko commented Jan 28, 2019

A ha - just seen your screenshot. I had the wrong impression then.

Thanks very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants