Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Automatic profiling on lag spike #42

Closed
Darkere opened this issue Apr 5, 2020 · 6 comments
Closed

[Feature Request] Automatic profiling on lag spike #42

Darkere opened this issue Apr 5, 2020 · 6 comments

Comments

@Darkere
Copy link
Contributor

Darkere commented Apr 5, 2020

We are currently being plagued by some specific bug which randomly causes the server to freeze until the watchdog causes it to crash.

As it's crashing it's not possible to generate a spark report about it making it very difficult to figure out what's causing it.

My request would be a feature where an automatic profiling can start if a tick takes longer than.. 5 min or so.

@i0xHeX
Copy link

i0xHeX commented Apr 5, 2020

On large spike watchdog reports the lag spike in console, showing the stack trace, where you can exactly see what caused that spike. Also in crash there will be crash log with all dumped threads and their stack traces at the moment. So you need to look at the Main Thread.

@Darkere
Copy link
Contributor Author

Darkere commented Apr 5, 2020

Main thread would be called Server Thread. Unfortunately, the stack traces that are produced there have proven completely useless many many times in the past.
Due to the instant cut off nature it often only shows parts of the problem and doesn't point towards the actual problem.

Also while there is potential that it points to the right direction, convincing mod devs that the problem is on their side (and the game didn't just coincidentally run their code) is difficult.

@MithrandirCraft
Copy link

MithrandirCraft commented Jun 14, 2020

Did you manage to profile your server's process? I'm running into the same issue.
"Plague" is a good definition for this, the server crashes once or twice a day, and there's no way I can profile it properly with spark.

Also if you'd send your watchdog for comparison that would be interesting too.

@Darkere
Copy link
Contributor Author

Darkere commented Jun 14, 2020

No. I've not found a way. However, I'm running into a similar issue, this time with a memory leak where I would need a heapdump under a certain condition. So I'm considering adding this feature into my own mod instead.

@MithrandirCraft
Copy link

FYI, I found, and managed to get to work a profiler that works for my case (Ubuntu terminal):
https://askubuntu.com/questions/1248311/running-jvmtop-profile-the-java-home-environment-variable/1250901#1250901

May not be what you need though.

@lucko
Copy link
Owner

lucko commented Dec 14, 2020

Sorry, don't think this is something I want to support with spark

@lucko lucko closed this as completed Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants