-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alters email column to citext type #51
Alters email column to citext type #51
Conversation
We now have support for citext luckyframework/avram#608 This migration, however, is actually for the specs for Authentic. Generated apps would use this migration. So we'd need to update both spots as well as I'd like to see a spec on this shard to just ensure that having a citext email will actually work with different case emails. Thanks for the suggestion on this! |
Thanks for the migration pointer ! I'll take care of this in the next days. Right off the bat, the two specs to be added I can think of are :
|
Yup! Those two specs would be great! Thanks |
…into downcase-email-before-save
While trying to write the specs, I realized :
We have nevertheless some decisions to make :
|
Also, copy-pasting code from the lucky-cli repo to test seems to me it could bite us later if we forget to update both repo. Is there any way to move all Authentic specific code from lucky-cli to the Authentic repo and make lucky-cli rely on Authentic shard for code generation ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well get this in since it'll now be default. Thanks for doing this!
Fixes #9
Inspired by : http://shuber.io/case-insensitive-unique-constraints-in-postgres/
Do not merge this as it is :
CIString
type in Avram to automatically create a citext column type and use it in Authentic ?)Edit : https://www.postgresql.org/docs/current/citext.html