Add virtual fields to create/update

luckyframework · May 25, 2018 · 9a867ee · 9a867ee
1 parent 3199435
commit 9a867ee
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/spec/virtual_form_spec.cr b/spec/virtual_form_spec.cr
@@ -9,7 +9,22 @@ private class TestVirtualForm < LuckyRecord::VirtualForm
   end
 end
 
+private class UserWithVirtual < User::BaseForm
+  virtual password : String
+end
+
 describe LuckyRecord::VirtualForm do
+  it "has create/update args for virtual fields" do
+    UserWithVirtual.create(password: "p@ssword") do |form, _user|
+      form.password.value = "p@ssword"
+    end
+
+    user = UserBox.create
+    UserWithVirtual.update(user, password: "p@ssword") do |form, _user|
+      form.password.value = "p@ssword"
+    end
+  end
+
   it "sets a form_name" do
     TestVirtualForm.new.form_name.should eq "test_virtual"
     TestVirtualForm.form_name.should eq "test_virtual"

diff --git a/src/lucky_record/needy_initializer_and_save_methods.cr b/src/lucky_record/needy_initializer_and_save_methods.cr
@@ -73,6 +73,9 @@ module LuckyRecord::NeedyInitializerAndSaveMethods
           {{ field[:name] }} : {{ field[:type] }} | Nothing{% if field[:nilable] %} | Nil{% end %} = Nothing.new,
         {% end %}
       {% end %}
+      {% for field in VIRTUAL_FIELDS %}
+        {{ field.var }} : {{ field.type }} | Nothing = Nothing.new,
+      {% end %}
     )
       form = new(
         {% if with_params %}params,{% end %}
@@ -116,6 +119,9 @@ module LuckyRecord::NeedyInitializerAndSaveMethods
             {{ field[:name] }} : {{ field[:type] }} | Nothing{% if field[:nilable] %} | Nil{% end %} = Nothing.new,
           {% end %}
         {% end %}
+        {% for field in VIRTUAL_FIELDS %}
+          {{ field.var }} : {{ field.type }} | Nothing = Nothing.new,
+        {% end %}
       )
       form = new(
         record,

diff --git a/src/lucky_record/virtual.cr b/src/lucky_record/virtual.cr
@@ -7,6 +7,10 @@ module LuckyRecord::Virtual
     {% end %}
   end
 
+  macro included
+    VIRTUAL_FIELDS = [] of Nil
+  end
+
   ensure_base_virtual_fields_method_is_present
 
   macro allow_virtual(*args, **named_args)
@@ -18,6 +22,8 @@ module LuckyRecord::Virtual
       {% raise "virtual must use just one type" %}
     {% end %}
 
+    {% VIRTUAL_FIELDS << type_declaration %}
+
     {% type = type_declaration.type %}
     {% name = type_declaration.var %}
     @_{{ name }} : LuckyRecord::Field({{ type }}?)?