validate_acceptance_of should add error for nil

luckyframework · Jun 7, 2018 · e32bd54 · e32bd54
1 parent ec32313
commit e32bd54
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/spec/validations_spec.cr b/spec/validations_spec.cr
@@ -177,6 +177,10 @@ describe LuckyRecord::Validations do
         user.terms.errors.should eq ["must be accepted"]
       end
 
+      validate(terms: nil) do |user|
+        user.terms.errors.should eq ["must be accepted"]
+      end
+
       validate(terms: true) do |user|
         user.terms.errors.empty?.should be_true
       end

diff --git a/src/lucky_record/validations.cr b/src/lucky_record/validations.cr
@@ -10,7 +10,7 @@ module LuckyRecord::Validations
   end
 
   private def validate_acceptance_of(field : FillableField(Bool?) | Field(Bool?), message = "must be accepted")
-    if field.value == false
+    if field.value != true
       field.add_error message
     end
   end