Support String primary key #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
reviewed
Jan 23, 2024
jwoertink
reviewed
Jan 23, 2024
jwoertink
reviewed
Jan 31, 2024
jwoertink
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Hey, sorry for the late review. I'm just getting back to this. Looked at it with some fresh eyes, and it looks great. I have an idea for ways you can set the primary key from the DB, but I think for now this is a great start. I don't see anything left to add, so I think I'm ready to merge if you are!
| skip_default_columns | ||
|
|
||
| table do | ||
| primary_key id : String = Random::Secure.hex |
|
@jwoertink sure! Let's start by merging this and we can iterate on it |
|
Amazing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resumes the work started in #927
Closes #21
Pending from the previous review:
String