Check for a connection before running db.create task #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤨 maybe time to move Avram to Gh actions too... |
jkthorne
reviewed
Jun 22, 2020
|
boom! Look at that. It kept failing on Travis, but passes on Gh Actions 🌮 🎉 |
paulcsmith
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #398
We currently have a
db.verify_connectiontask, but this task only checks that you can connect to the database. When you rundb.create, the database doesn't exist yet which means we have no way to check for the connection.This update checks that you can connect to the postges engine before running the db.create. This allows us to catch the error and return a nicer error message to help users figure out what they need to do.