Attempt parsing raw string before calling to_json #806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to luckyframework/lucky#1661
When we call
params.nested(:user)
we get back aHash(String, String)
. The String value is a stringified version of the json object which the current implementation would not parse correctly. This new overload attempts to parse the raw string value before calling.to_json
on it.This does change behavior:
I believe these tradeoffs are acceptable because most
JSON::Any
columns aren't doing scalar values anyways and this new way is more true to intention especially being constrained by howLucky::Params
works.