Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors should have the variables as properties (#819) #823

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Errors should have the variables as properties (#819) #823

merged 1 commit into from
Mar 8, 2022

Conversation

jochenseeber
Copy link
Contributor

  • Added constructor arguments as properties
  • Made InvalidOperationError generic since there seems no common parent class for operations
    • Is there a better way in Crystal?

jwoertink
jwoertink reviewed Mar 7, 2022
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I just had one suggestion for InvalidOperationError. I'm not 100% sure if that will work, but if it does, then it'll make it easier to not have to change the other uses of it.

src/avram/errors.cr Show resolved Hide resolved
src/avram/errors.cr Show resolved Hide resolved
jwoertink
jwoertink approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, it all looks good to me 👍

@jwoertink jwoertink merged commit c798fbb into luckyframework:main Mar 8, 2022
@jwoertink jwoertink mentioned this pull request Apr 8, 2022
Closed
jwoertink added a commit that referenced this pull request Apr 8, 2022
@jwoertink
Reverting part of #823 due to a Crystal compiler bug trying to downca…
311576c 
…st a generic inherited from a non-generic affecting at least 1.2.x. Fixes #834
jwoertink added a commit that referenced this pull request Apr 8, 2022
@jwoertink
Reverting part of #823 due to a Crystal compiler bug trying to downca…
fb5e7f5 
…st a generic inherited from a non-generic affecting at least 1.2.x. Fixes #834 (#835)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jochenseeber @jwoertink