Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile error when preloading optional associations #925

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Fix compile error when preloading optional associations #925

merged 1 commit into from
Jan 18, 2023

Conversation

akadusei
Copy link
Contributor

Fixes #922

@akadusei akadusei marked this pull request as ready for review January 17, 2023 21:59
jwoertink
jwoertink approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna approve this, but @matthewmcgarvey has spent way more time in this section than me. So I'll leave it just for a second pair of eyes.

matthewmcgarvey
matthewmcgarvey approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@matthewmcgarvey matthewmcgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@matthewmcgarvey matthewmcgarvey merged commit 81add34 into luckyframework:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

@matthewmcgarvey matthewmcgarvey matthewmcgarvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile error for optional association preloads
3 participants
@akadusei @jwoertink @matthewmcgarvey