Revert and cleanup the verify_connection task #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
commented
Dec 28, 2023
| @@ -23,7 +23,6 @@ Avram.initialize_logging | |||
|
|
|||
| Db::Create.new(quiet: true).run_task | |||
| Db::Migrate.new(quiet: true).run_task | |||
| Db::VerifyConnection.new(quiet: true).run_task | |||
There was a problem hiding this comment.
This isn't needed. We test this both in the spec, and through the integration test script on CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #902
We've had users in the past that get started with Lucky and have a horrible first experience because their setup script never completes. In this last case, it was only the
verify_connectiontask that was failing, but not very apparent. We used to have the code work this way, but changed it to callopen.close. Somehow, that must be causing some sort of race condition and randomly fails for some people.I wasn't ever able to recreate the issue, but I'd rather give people a nice first experience, so I'm just reverting this for now.