Make emails serializable #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Wow, that's a pretty clever way around it.
I guess if you wanted to add the attachments to your serialization to ship off to a 3rd party, you'd have to probably handroll anyway so you could decide if you're doing a base64 hash of the content, or just a URL to the file or whatever 🤔
I'm cool with this, but I also haven't used this feature, so I'm not sure if this affects anything. Maybe @manveru can give it some 👀
|
It seems fine to me as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91