Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to turn off session and cookies for paths #1178

Closed
confact opened this issue Jun 9, 2020 · 4 comments
Closed

Add support to turn off session and cookies for paths #1178

confact opened this issue Jun 9, 2020 · 4 comments

Comments

@confact
Copy link
Contributor

confact commented Jun 9, 2020

It is unnecessary to send cookies headers on assets paths and on api when it is for real api.

I use own session handler to not set cookie on users browser as they just sent events and load javascript. It is not nice for the privacy and can break some laws if not thoughtful.

With the new session changes I can't set this anymore.

The session handler i use exists in kindmetrics/kindmetrics repo. Will update this issue with link when I can.

@paulcsmith
Copy link
Member

This is a great idea. I imagine we could have a simple macro like disable_cookies that can be called in an action. Then we'd need to add something to TextResponse like enable_cookies = true and it could be set to false if the cookies are not supposed to be written

@wout
Copy link
Contributor

wout commented Jun 9, 2020

@paulcsmith I was thinking the exact same thing. Since I've been there recently, I can work on that if you want.

@paulcsmith
Copy link
Member

That'd be fantastic! Thanks @wout

@wout wout mentioned this issue Jun 10, 2020
5 tasks
@confact
Copy link
Contributor Author

confact commented Jun 10, 2020

Closing this as @wout is fast to fix things :)

@confact confact closed this as completed Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants