Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow model to be generated with JSON::Any column type #1375

Merged
merged 1 commit into from
Dec 31, 2020
Merged

Allow model to be generated with JSON::Any column type #1375

merged 1 commit into from
Dec 31, 2020

Conversation

matthewmcgarvey
Copy link
Member

Purpose

Fixes #1311

Description

This allows users to generate models and resources through the cli with a JSON::Any column type

lucky gen.model Post title:String content:String settings:JSON::Any

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@jkthorne
Copy link
Contributor

I like how the test used this as a type too complex and now we have implemented it.

jwoertink
jwoertink approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow... seriously? 😂 I'm probably the one that added that error message. Look at us moving in to the future!

@matthewmcgarvey matthewmcgarvey merged commit c31bcd3 into luckyframework:master Dec 31, 2020
@matthewmcgarvey matthewmcgarvey deleted the matthewmcgarvey/issue1311 branch December 31, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lucky gen.model missing datatypes
3 participants
@matthewmcgarvey @jkthorne @jwoertink