Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support VueJS style attributes on tag_defaults #1452

Merged
merged 2 commits into from Apr 2, 2021
Merged

Support VueJS style attributes on tag_defaults #1452

merged 2 commits into from Apr 2, 2021

Conversation

matthewmcgarvey
Copy link
Member

Purpose

Fixes #1409

Description

Allows using VueJS style attributes (like @click) when using tag_defaults. This only works on Crystal 1.0.0 because of crystal-lang/crystal#10388

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

jwoertink
jwoertink approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boom

@matthewmcgarvey matthewmcgarvey merged commit 139cc28 into luckyframework:master Apr 2, 2021
@matthewmcgarvey matthewmcgarvey deleted the mm/issue1409 branch April 2, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to use specific VueJS attribute in Shared::Field
2 participants
@matthewmcgarvey @jwoertink