Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate model with delete operation #1594

Merged
merged 2 commits into from Oct 27, 2021
Merged

Generate model with delete operation #1594

merged 2 commits into from Oct 27, 2021

Conversation

lqmanh
Copy link
Contributor

@lqmanh lqmanh commented Oct 21, 2021 •
edited

Purpose

Resolves #1590.

Description

lucky gen.model should generate DeleteModel operation too, like in lucky gen.resource.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

jwoertink
jwoertink approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This looks great to me. Thanks so much for adding this in 🚀

@jwoertink jwoertink merged commit 74c049f into luckyframework:master Oct 27, 2021
@lqmanh lqmanh deleted the features/gen-model-with-delete-operation branch October 27, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The gen.model task doesn't generate a DeleteOperation
2 participants
@lqmanh @jwoertink