Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty response_id () when response_id is empty #1630

Conversation

grepsedawk
Copy link
Contributor

Resolves #1626

Purpose

Describe the feature or issue and link to the related issue.
If no issue has been opened about this, be sure to open an issue first to discuss the need for this PR.

Description

Please include any relevant code samples or screen shots that may help to overview of this PR.
Link to specific lines of code, or examples if you need to.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@grepsedawk grepsedawk force-pushed the in-crystal-we-dont-use-empty-parenthesis-for-methods branch from fd127ec to 3a38d11 Compare December 22, 2021 07:56
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for fixing this

@jwoertink jwoertink merged commit a12ddfb into luckyframework:master Dec 22, 2021
@grepsedawk grepsedawk deleted the in-crystal-we-dont-use-empty-parenthesis-for-methods branch December 22, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pretty logger still logs () when there's no request id
2 participants