Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links for discord and code of conduct #1633

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Update links for discord and code of conduct #1633

merged 2 commits into from
Jan 3, 2022

Conversation

colinkey
Copy link
Contributor

@colinkey colinkey commented Jan 2, 2022

Purpose

Updates documentation to close #1631 and #1632

Description

For #1631, searched through the codebase to update almost all references from the discord to the luckyframework.com/chat link. The only unchanged reference is the badge in the README.

For #1632, updated the contributing guidelines to remove the reference to the thoughtbot code of conduct as well as making a few updates to urls that while still worked, pointed to an outdated repo name.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@colinkey colinkey changed the title Update links discord code of conduct Update links for discord and code of conduct Jan 2, 2022
Copy link
Member

@matthewmcgarvey matthewmcgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 🎉

Copy link
Member

@edwardloveall edwardloveall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @colinkey!

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks so much for doing this

@jwoertink jwoertink merged commit aa0eb3a into luckyframework:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update chat link
4 participants