Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom error on default_format macro #1638

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Remove custom error on default_format macro #1638

merged 1 commit into from
Jan 4, 2022

Conversation

matthewmcgarvey
Copy link
Member

Standard error message is just as helpful, if not more so, than our custom one.

Before

Screen Shot 2022-01-03 at 10 31 56 PM

After

Screen Shot 2022-01-03 at 10 32 06 PM

jwoertink
jwoertink approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's fair enough 👍

@matthewmcgarvey matthewmcgarvey merged commit 7d5b330 into luckyframework:master Jan 4, 2022
@matthewmcgarvey matthewmcgarvey deleted the default-format-error branch January 4, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthewmcgarvey @jwoertink