Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimenting with optional vite integration. #1729

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Experimenting with optional vite integration. #1729

merged 2 commits into from
Sep 9, 2022

Conversation

jwoertink
Copy link
Member

Purpose

Ref #1724

Description

This is an experiment to test if we can keep mix integration while allowing for vite to be used optionally. In theory, you would just need to update your load_manifest() call to point to ./public/manifest.json, and a second use_vite: true arg. The actual setup for Vite would still need to be done, but you can use https://github.com/jwoertink/vite_lucky/ as a sort of reference.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

Comment on lines 10 to +11
Lucky::AssetHelpers.load_manifest
Lucky::AssetHelpers.load_manifest("./public/vite-manifest.json", use_vite: true)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice you would never run this more than once, but this was the only way I could test it since it happens at compile-time.

@jwoertink jwoertink merged commit e167dc5 into main Sep 9, 2022
@jwoertink jwoertink deleted the swap_mix branch September 9, 2022 21:17
@jwoertink jwoertink mentioned this pull request Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant