Add release task #602
Merged
Add release task #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome @HarrisonB Thanks so much for taking this on! It may take us a couple days to look at this but on first glance it looks like a great start. |
paulcsmith
reviewed
Oct 3, 2018
There was a problem hiding this comment.
The code here looks perfect. Could you add a spec for it to make sure that it saves the binary? The tricky part will be cleaning up afterward I think. Here is a rough idea of what it might look like:
# Uses the CleanupHelper. Remember to include it: https://github.com/luckyframework/lucky/blob/master/spec/support/cleanup_helper.cr#L6
with_cleanup do
File.write "./src/server.cr", "1 + 1"
Release.new.call
File.exists?("src.server")
endI think something simple like this is sufficient to make sure the task works. If you want to test the output you could pass in a IO::Memory to initialize, but I don't think that is necessary. It's up to you! Let me know if you have any questions or if I didn't explain things clearly
paulcsmith
reviewed
Oct 5, 2018
| File.exists?("./server").should be_false | ||
| end | ||
| end | ||
| end |
|
Thanks for tackling this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #594
Not exactly sure how to add tests for this (though I'm not sure if they're necessary).