Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distance_of_time_in_words returns a string instead of text element #781

Merged
merged 9 commits into from Jun 1, 2019
Merged

distance_of_time_in_words returns a string instead of text element #781

merged 9 commits into from Jun 1, 2019

Commits on May 19, 2019

  1. distance_of_time_in_words returns a string instead of text element

    @edwardloveall
    edwardloveall committed May 19, 2019
    Copy the full SHA
    83b36ff View commit details
    Browse the repository at this point in the history

Commits on May 25, 2019

  1. Documentation for simple_format

    @edwardloveall
    edwardloveall committed May 25, 2019
    Copy the full SHA
    a74d354 View commit details
    Browse the repository at this point in the history

  2. pluralize, word_wrap, to_sentence, and cycle return strings 

    The goal is to make these easier to use inside other tags. The problem
was that these would all output to the IO, so if you tried to use these
in an element, it would print out the whole page HTML.
    @edwardloveall
    edwardloveall committed May 25, 2019
    Copy the full SHA
    31bca47 View commit details
    Browse the repository at this point in the history

  3. Return a string and add docs for highlight text helper

    @edwardloveall
    edwardloveall committed May 25, 2019
    Copy the full SHA
    68c8ced View commit details
    Browse the repository at this point in the history

  4. Allow excerpt to be used inside tags and add docs

    @edwardloveall
    edwardloveall committed May 25, 2019
    Copy the full SHA
    f082a0f View commit details
    Browse the repository at this point in the history

  5. Make truncate_text public and add truncate docs

    @edwardloveall
    edwardloveall committed May 25, 2019
    Copy the full SHA
    10e85d9 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2019

  1. Remove extraneous string conversions in text helper tests

    @edwardloveall
    edwardloveall committed May 26, 2019
    Copy the full SHA
    b3f8d0f View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @edwardloveall
    edwardloveall committed May 26, 2019
    Copy the full SHA
    3b32d13 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2019

  1. View helper methods that don't return String should return Nil 

    This change also made the tests have to change since we can no longer
grab the output of the text helper to a string and then compare it with
another string.
    @edwardloveall
    edwardloveall committed Jun 1, 2019
    Copy the full SHA
    537ee85 View commit details
    Browse the repository at this point in the history