adding in a generated default DB port. #469
Conversation
…oving the default port.
There was a problem hiding this comment.
I think this answers the question I just left on the other PR :P
Is there some way we could set the default port when needed in Avram? Like only if you’re not using a socket or something? I don’t really understand the other change so maybe I’m just spouting nonsense :P
|
We were force specifying the default port before, but I'm pretty sure postgres will just fallback to it's default without specifying anyway, so this change isn't totally required. This just moves that setting down to the user level so people have the option to not use it if they need. Otherwise this should all work as it does now. |
|
Ah ok so people can leave it off and Postgres will just the default port if not given?
If so that sounds good to me!
… On Mar 17, 2020, at 7:27 PM, Jeremy Woertink ***@***.***> wrote:
We were force specifying the default port before, but I'm pretty sure postgres will just fallback to it's default without specifying anyway, so this change isn't totally required. This just moves that setting down to the user level so people have the option to not use it if they need. Otherwise this should all work as it does now.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Yeah, passing in the port isn't necessary if postgres is running on the default port. And really we're just talking about this update for development, so production isn't affected at all. The main benefit here is just that if someone needs to change the port locally, it's a lot more apparent how and where to do that. (or if using docker for development) |
…oving the default port. (#469)
In the PR luckyframework/avram#333 we are removing the default port value to fix some other issues with connecting to sockets. This PR adds in the port default to your new generated lucky app.