Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default generated app to build a generic target #742

Merged
merged 1 commit into from
Mar 27, 2022

Conversation

grepsedawk
Copy link
Contributor

This allows for easier devops/DX by being able to have a reliable bin/app generated on build
Which greatly cleans up universal Dockerfiles

Resolves #735

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a few other places this has to be changed. Like

web: bin/<%= project_name %>
for example

Also, I forget, but maybe the Heroku buildpack may also need to be updated? I'll try to dig around the ecosystem a bit and see where all this gets used. Thanks for getting this started!

@grepsedawk
Copy link
Contributor Author

I'll grep for project_name and see if I find other places.

@grepsedawk
Copy link
Contributor Author

Ooh nice, one .ecr taken away, certainly a win in my eyes
@jwoertink didn't find any other refs that need to change

@grepsedawk grepsedawk marked this pull request as draft March 19, 2022 18:30
This allows for easier devops/DX by being able to have a reliable bin/app generated on build
Which greatly cleans up universal Dockerfiles

Resolves luckyframework#735
@grepsedawk grepsedawk marked this pull request as ready for review March 21, 2022 06:24
@grepsedawk
Copy link
Contributor Author

Oop, forgot to mark this as ready for review

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jwoertink jwoertink merged commit ff2c0da into luckyframework:main Mar 27, 2022
@grepsedawk grepsedawk deleted the up-and-up branch March 27, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make shard.yml target generic
2 participants