Include chrome driver binary in shard #17
Milestone
Comments
paulcsmith
added a commit
that referenced
this issue
Jun 9, 2018
Closes #17 This will make it a lot easier to get started and you won't have to worry about conflicting binaries and path issues.
paulcsmith
added a commit
that referenced
this issue
Jun 9, 2018
Closes #17 This will make it a lot easier to get started and you won't have to worry about conflicting binaries and path issues.
paulcsmith
added a commit
that referenced
this issue
Jun 9, 2018
Closes #17 This will make it a lot easier to get started and you won't have to worry about conflicting binaries and path issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This will save a lot of hassle with versioning, conflicts with the ruby chromedriver gem, etc. It should just work.
It should look at the OS and decide to use either the Mac 64 or Linux build automatically
I think this can be used to detect OS: https://github.com/crystal-lang/crystal/blob/cd03b6f0f46d0e5d8a438b1b6eff0c6498fa79bf/src/compiler/crystal/codegen/debug.cr#L22
Or use
uname -a. MacOS is Darwin: https://unix.stackexchange.com/questions/88644/how-to-check-os-and-version-using-a-linux-commandThe text was updated successfully, but these errors were encountered: