Switch selenium libraries #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is definitely a good move. This will let us stay more current and give us more options. I'll need to dig in a bit more to see how this is all working, but I like what I'm seeing so far! |
|
If this gets approved, I've added this ability to run the driver processes to the library so that the chromedriver code can be removed |
jwoertink
approved these changes
May 9, 2020
There was a problem hiding this comment.
It all looks good to me! Let's see what @paulcsmith says, but I think this will be a great addition
paulcsmith
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75
Moving to https://github.com/matthewmcgarvey/selenium.cr
The previous selenium library was made to support the obsolete JsonWireProtocol which is not guaranteed to be followed by browsers. Moving to the W3C standard which this new library supports gives greater compatibility to browsers as it is the standard all the main selenium libraries use.
This also gives lucky_flow the potential to be used to test against more than just Chrome.