Some code cleanup #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
commented
Aug 27, 2023
| # name "app.send_daily_notifications" | ||
| # task_name "app.send_daily_notifications" |
There was a problem hiding this comment.
This was leftover from #19
jwoertink
commented
Aug 27, 2023
| @@ -279,5 +279,5 @@ abstract class LuckyTask::Task | |||
| end | |||
|
|
|||
| abstract def call | |||
There was a problem hiding this comment.
I can't add a return type to this method since it can return anything you want. The specs currently rely on the return value of this to help test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly just adding types around the code. Only big change here is a new
Runner.register_taskmethod instead of using the<<operator. Functionally, it should be the same