Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotwire error triggering on HTML conversion #947

Closed
robcole opened this issue Mar 7, 2022 · 3 comments · Fixed by #948
Closed

Hotwire error triggering on HTML conversion #947

robcole opened this issue Mar 7, 2022 · 3 comments · Fixed by #948
Labels
bug a bug or issue related to the codebase html2lucky Anything related to the HTML -> Lucky converter

Comments

@robcole
Copy link
Contributor

robcole commented Mar 7, 2022

Replication: attempt to convert any HTML at https://luckyframework.org/html or main branch.

# Browser Console Error Log

Error: Form responses must redirect to another location
    at I.requestSucceededWithResponse (app.js?id=20f4d48f01b21bc54b91c52f76f76c03:2:12395)
    at j.receive (app.js?id=20f4d48f01b21bc54b91c52f76f76c03:2:7148)

Relevant issues:

hotwired/turbo#22
hotwired/turbo#73
hotwired/turbo#375

@jwoertink
Copy link
Member

oh, so it's turbo related? Maybe we need to go back to turbolinks for the time being? 🤔

@jwoertink jwoertink added bug a bug or issue related to the codebase html2lucky Anything related to the HTML -> Lucky converter labels Mar 7, 2022
@robcole
Copy link
Contributor Author

robcole commented Mar 7, 2022

Yeah, I’m gonna take a poke at what it’d take to fix it first, and downgrade us if not.

@jwoertink
Copy link
Member

Here's the PR where I changed it #932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug or issue related to the codebase html2lucky Anything related to the HTML -> Lucky converter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants