Replacing turbolinks with turbo. #932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… randomly disappearing. Fixes #917
matthewmcgarvey
approved these changes
Feb 17, 2022
robcole
added a commit
to robcole/website
that referenced
this pull request
Mar 7, 2022
…e search randomly disappearing. Fixes luckyframework#917 (luckyframework#932)" This reverts commit bb320a8. # Conflicts: # package.json
jwoertink
pushed a commit
that referenced
this pull request
Mar 8, 2022
* Revert "Replacing turbolinks with turbo. This fixes the issue with the search randomly disappearing. Fixes #917 (#932)" This reverts commit bb320a8. # Conflicts: # package.json * Ensure docsearch is loaded on every turbo pageload This seems to resolve the issue around the searchbox not being visible in some situations. * Switch watcher port to 3000 by default Use of port 5000 has been deprecated in upstream CLI builds due to its conflicts on OSX. This allows for local dev in Mac-based environments more easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #917
I probably could have just moved the docsearch in to the turbolinks load block, but after seeing that turbolinks is officially archived, I decided to give turbo a shot. It was a pretty easy migration, and the search no longer disappears on us, so win win!