Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compoundtypesplitter): handle class names with digits #36

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

lucsorel
Copy link
Owner

py2puml should handle class names that include digits, like:

class int64:
    def __init__(self, value: int) -> None:
        self.value: int = value

class Main:
    def __init__(self):
        self.a: list[int64] = [int64(0)] * 5

@lucsorel lucsorel linked an issue Jan 12, 2023 that may be closed by this pull request
@lucsorel lucsorel self-assigned this Jan 12, 2023
@lucsorel lucsorel added the bug Something isn't working label Jan 12, 2023
README.md Outdated
@@ -181,7 +181,8 @@ poetry run python -m pytest -v --cov=py2puml --cov-branch --cov-report term-miss

# Changelog

* `0.6.0`: handle abstract classes
* `0.6.1`: handle class names with digits
* `0.6.1`: handle abstract classes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 0.6.0

Copy link

@anaellorimier anaellorimier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little typo in the changelog, otherwise it looks good to me !

@lucsorel
Copy link
Owner Author

thanks @anaellorimier for the review. I fixed the changelog. Can you resume the review, please?

@lucsorel lucsorel merged commit d708fac into main Jan 12, 2023
@lucsorel lucsorel deleted the 35-valueerror-raised-when-compound-types-have-digits branch January 12, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError raised when compound types have digits
2 participants