Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32 add namespace structure in the PlantUML result #37

Merged
merged 16 commits into from
Feb 12, 2023

Conversation

lucsorel
Copy link
Owner

@lucsorel lucsorel commented Feb 9, 2023

The main feature added by this PR is to add this block at the beginning of the file so that data structures are displayed as grouped by their module structure:

@startuml py2puml.domain
namespace py2puml.domain {
  namespace package {}
  namespace umlclass {}
  namespace umlitem {}
  namespace umlenum {}
  namespace umlrelation {}
}
' ...
@enduml

Other features included:

  • homogenization of the way types are displayed in module inspection (dataclasses, enums, named tuples, etc.) and AST parsing (class constructors)
  • handling of forward references
  • deduplication of similar composition relationships

@lucsorel lucsorel linked an issue Feb 9, 2023 that may be closed by this pull request
@lucsorel lucsorel self-assigned this Feb 9, 2023
@lucsorel
Copy link
Owner Author

lucsorel commented Feb 9, 2023

@jjerphan @doyou89 @jonykalavera would you be interested in reviewing (even partially) this pull request, if you please?

I know it is a heavy one 😬 I fixed a couple of typing things while writing this contribution.

An external view is always interesting

@jjerphan
Copy link
Contributor

jjerphan commented Feb 9, 2023

Hi @lucsorel, as a user, I like this feature. 👍

As another project's maintainers and as a reviewer, I unfortunately have zero bandwidth to review it. 😕

@lucsorel
Copy link
Owner Author

lucsorel commented Feb 9, 2023

Hi @lucsorel, as a user, I like this feature. +1

As another project's maintainers and as a reviewer, I unfortunately have zero bandwidth to review it. confused

Thanks for the response, I totally understand 👍

@lucsorel lucsorel merged commit db134ca into main Feb 12, 2023
@lucsorel lucsorel deleted the 32-add-namespace-structure-in-the-plantuml-result branch February 12, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add namespace structure in the plantuml result
2 participants