Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: list indices must be integers or slices, not tuple #14

Closed
jnluy opened this issue May 16, 2019 · 11 comments
Closed

TypeError: list indices must be integers or slices, not tuple #14

jnluy opened this issue May 16, 2019 · 11 comments

Comments

@jnluy
Copy link

jnluy commented May 16, 2019

The test failed on a new installation of effmass on Python 3.6.

@lucydot
Copy link
Owner

lucydot commented May 16, 2019

Hello, thanks for flagging this up - can you give me a couple of more details so I can trace the problem - which test failed?

@jnluy
Copy link
Author

jnluy commented May 17, 2019 via email

@lucydot
Copy link
Owner

lucydot commented May 17, 2019

Hello, I'm afraid the error log isn't attached - I think you will need to log into github and drag and drop the file (https://help.github.com/en/articles/file-attachments-on-issues-and-pull-requests). Automated testing of effmass happens here, and it seems to be passing all tests, so I'm a little stumped why it is failing for you - might be something system dependant. Just to check that you are running the python3 -m pytest command from inside the effmass folder? (pip3 show effmass will tell you where effmass is installed)

@jnluy
Copy link
Author

jnluy commented May 17, 2019

err.log

@bjmorgan
Copy link
Contributor

This looks like it might be an issue introduced by a recent change to the vasppy API, which is used to parse the PROCAR files. If so, it should be fixed in this pull request: #15

@lucydot
Copy link
Owner

lucydot commented May 18, 2019

Hi, thanks @bjmorgan for submitting the PR request - this has been merged with effmass, and I have made a new release (v1.1.0) which should now be available through PyPI. @jnluy if you update effmass via pip it should pass all tests 🤞

@lucydot
Copy link
Owner

lucydot commented May 18, 2019

Once you confirm the problem is fixed @jnluy I'll close the issue - thanks again for flagging it up.
-Lucy

@jnluy
Copy link
Author

jnluy commented May 21, 2019

pytest still fails, but with another error now
err2.log

@bjmorgan
Copy link
Contributor

pytest still fails, but with another error now
err2.log

The error log appears to show the old version of effmass. Can you please check what version you have installed using pip list?

@jnluy
Copy link
Author

jnluy commented May 21, 2019

pytest still fails, but with another error now
err2.log

The error log appears to show the old version of effmass. Can you please check what version you have installed using pip list?

You are right. I was sitting in the wrong folder when calling pytest. Thank you for the quick fix!

@lucydot
Copy link
Owner

lucydot commented Jun 17, 2019

Thanks to PR #15 from @bjmorgan the latest versions of vasppy and effmass are now compatible with each other and so I am closing this issue.

@lucydot lucydot closed this as completed Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants