Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test cases for Aims #21

Merged
merged 11 commits into from
Mar 8, 2021
Merged

Added test cases for Aims #21

merged 11 commits into from
Mar 8, 2021

Conversation

MatthiasGolomb
Copy link
Contributor

Testcases on Ge for spin-polarised, non spin-polarised and spin-orbit coupling added.

@lucydot
Copy link
Owner

lucydot commented Dec 29, 2020

Hi @MatthiasGolomb sorry for the delay in reviewing this. It looks good though a few changes before accepting the PR:

  • is the tests/.gitignore file needed? I think it can be deleted.
  • edit the inputs.py module docstring to include new DataAims functionality
  • restructure the inputs.py module so that check_data() becomes a module-level function rather than class method. Currently the same method is repeated twice for the Data and DataAims class.

I'm happy to make these changes if you give me permission to push to your fork. I think there should be a tick box option for this next to the pull request.

Thanks for sharing!

@lucydot lucydot merged commit 89605a3 into lucydot:master Mar 8, 2021
@lucydot
Copy link
Owner

lucydot commented Mar 8, 2021

OK, I'm going to go ahead and merge then make the small changes suggested as none of them are critical to performance

@lucydot lucydot linked an issue Mar 8, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use effmass with AIMS
2 participants