-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test cases for Aims #21
Conversation
the Data class to Data_Vasp, such as to distinguish between the two codes.
smoothly then. Will update the tests section after ensuring the new class hasn't messed with the old tests.
Hi @MatthiasGolomb sorry for the delay in reviewing this. It looks good though a few changes before accepting the PR:
I'm happy to make these changes if you give me permission to push to your fork. I think there should be a tick box option for this next to the pull request. Thanks for sharing! |
OK, I'm going to go ahead and merge then make the small changes suggested as none of them are critical to performance |
Testcases on Ge for spin-polarised, non spin-polarised and spin-orbit coupling added.