Hotfix: Address missing constraint issue #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
changed the title
michplunkett
requested review from
b-meson,
abandoned-prototype,
null-space-0 and
AetherUnbound
Closed
michplunkett
changed the title
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
## Fixes issue lucyparsons#1005 ## Description of Changes This fixes the issue we were having with trying to drop the `faces_user_id_fkey` in the push to `main`. What happened was the `faces_user_id_fkey` wasn't saved under a name in the previous database model. PosgreSQL will drop any attached constraints when a column is dropped (presuming there are no `CASCADE` effects), so I am removing the `drop_constraint` commands and JUST dropping the column. This will allow PostgreSQL to take care of the constraint problem for us. ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment. <details><summary>DB migration output</summary> ```console :/usr/src/app$ flask db upgrade [2023-08-03 21:48:37,989] INFO in __init__: OpenOversight startup ... INFO [sqlalchemy.engine.Engine] COMMIT INFO [alembic.runtime.migration] Context impl PostgresqlImpl. INFO [alembic.runtime.migration] Will assume transactional DDL. INFO [alembic.runtime.migration] Running upgrade 18f43ac4622f -> b38c133bed3c, add created_by and created_at columns :/usr/src/app$ flask db downgrade [2023-08-03 21:48:50,167] INFO in __init__: OpenOversight startup ... INFO [sqlalchemy.engine.Engine] COMMIT INFO [alembic.runtime.migration] Context impl PostgresqlImpl. INFO [alembic.runtime.migration] Will assume transactional DDL. INFO [alembic.runtime.migration] Running downgrade b38c133bed3c -> 18f43ac4622f, add created_by and created_at columns :/usr/src/app$ flask db upgrade [2023-08-03 21:48:58,053] INFO in __init__: OpenOversight startup ... INFO [sqlalchemy.engine.Engine] COMMIT INFO [alembic.runtime.migration] Context impl PostgresqlImpl. INFO [alembic.runtime.migration] Will assume transactional DDL. INFO [alembic.runtime.migration] Running upgrade 18f43ac4622f -> b38c133bed3c, add created_by and created_at columns :/usr/src/app$ ``` </details>
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
## Fixes issue lucyparsons#1005 ## Description of Changes This fixes the issue we were having with trying to drop the `faces_user_id_fkey` in the push to `main`. What happened was the `faces_user_id_fkey` wasn't saved under a name in the previous database model. PosgreSQL will drop any attached constraints when a column is dropped (presuming there are no `CASCADE` effects), so I am removing the `drop_constraint` commands and JUST dropping the column. This will allow PostgreSQL to take care of the constraint problem for us. ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment. <details><summary>DB migration output</summary> ```console :/usr/src/app$ flask db upgrade [2023-08-03 21:48:37,989] INFO in __init__: OpenOversight startup ... INFO [sqlalchemy.engine.Engine] COMMIT INFO [alembic.runtime.migration] Context impl PostgresqlImpl. INFO [alembic.runtime.migration] Will assume transactional DDL. INFO [alembic.runtime.migration] Running upgrade 18f43ac4622f -> b38c133bed3c, add created_by and created_at columns :/usr/src/app$ flask db downgrade [2023-08-03 21:48:50,167] INFO in __init__: OpenOversight startup ... INFO [sqlalchemy.engine.Engine] COMMIT INFO [alembic.runtime.migration] Context impl PostgresqlImpl. INFO [alembic.runtime.migration] Will assume transactional DDL. INFO [alembic.runtime.migration] Running downgrade b38c133bed3c -> 18f43ac4622f, add created_by and created_at columns :/usr/src/app$ flask db upgrade [2023-08-03 21:48:58,053] INFO in __init__: OpenOversight startup ... INFO [sqlalchemy.engine.Engine] COMMIT INFO [alembic.runtime.migration] Context impl PostgresqlImpl. INFO [alembic.runtime.migration] Will assume transactional DDL. INFO [alembic.runtime.migration] Running upgrade 18f43ac4622f -> b38c133bed3c, add created_by and created_at columns :/usr/src/app$ ``` </details>
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 9, 2023
## Fixes issue lucyparsons#1005 ## Description of Changes This fixes the issue we were having with trying to drop the `faces_user_id_fkey` in the push to `main`. What happened was the `faces_user_id_fkey` wasn't saved under a name in the previous database model. PosgreSQL will drop any attached constraints when a column is dropped (presuming there are no `CASCADE` effects), so I am removing the `drop_constraint` commands and JUST dropping the column. This will allow PostgreSQL to take care of the constraint problem for us. ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment. <details><summary>DB migration output</summary> ```console :/usr/src/app$ flask db upgrade [2023-08-03 21:48:37,989] INFO in __init__: OpenOversight startup ... INFO [sqlalchemy.engine.Engine] COMMIT INFO [alembic.runtime.migration] Context impl PostgresqlImpl. INFO [alembic.runtime.migration] Will assume transactional DDL. INFO [alembic.runtime.migration] Running upgrade 18f43ac4622f -> b38c133bed3c, add created_by and created_at columns :/usr/src/app$ flask db downgrade [2023-08-03 21:48:50,167] INFO in __init__: OpenOversight startup ... INFO [sqlalchemy.engine.Engine] COMMIT INFO [alembic.runtime.migration] Context impl PostgresqlImpl. INFO [alembic.runtime.migration] Will assume transactional DDL. INFO [alembic.runtime.migration] Running downgrade b38c133bed3c -> 18f43ac4622f, add created_by and created_at columns :/usr/src/app$ flask db upgrade [2023-08-03 21:48:58,053] INFO in __init__: OpenOversight startup ... INFO [sqlalchemy.engine.Engine] COMMIT INFO [alembic.runtime.migration] Context impl PostgresqlImpl. INFO [alembic.runtime.migration] Will assume transactional DDL. INFO [alembic.runtime.migration] Running upgrade 18f43ac4622f -> b38c133bed3c, add created_by and created_at columns :/usr/src/app$ ``` </details>
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Nov 11, 2023
## Fixes issue lucyparsons#1005 ## Description of Changes This fixes the issue we were having with trying to drop the `faces_user_id_fkey` in the push to `main`. What happened was the `faces_user_id_fkey` wasn't saved under a name in the previous database model. PosgreSQL will drop any attached constraints when a column is dropped (presuming there are no `CASCADE` effects), so I am removing the `drop_constraint` commands and JUST dropping the column. This will allow PostgreSQL to take care of the constraint problem for us. ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment. <details><summary>DB migration output</summary> ```console :/usr/src/app$ flask db upgrade [2023-08-03 21:48:37,989] INFO in __init__: OpenOversight startup ... INFO [sqlalchemy.engine.Engine] COMMIT INFO [alembic.runtime.migration] Context impl PostgresqlImpl. INFO [alembic.runtime.migration] Will assume transactional DDL. INFO [alembic.runtime.migration] Running upgrade 18f43ac4622f -> b38c133bed3c, add created_by and created_at columns :/usr/src/app$ flask db downgrade [2023-08-03 21:48:50,167] INFO in __init__: OpenOversight startup ... INFO [sqlalchemy.engine.Engine] COMMIT INFO [alembic.runtime.migration] Context impl PostgresqlImpl. INFO [alembic.runtime.migration] Will assume transactional DDL. INFO [alembic.runtime.migration] Running downgrade b38c133bed3c -> 18f43ac4622f, add created_by and created_at columns :/usr/src/app$ flask db upgrade [2023-08-03 21:48:58,053] INFO in __init__: OpenOversight startup ... INFO [sqlalchemy.engine.Engine] COMMIT INFO [alembic.runtime.migration] Context impl PostgresqlImpl. INFO [alembic.runtime.migration] Will assume transactional DDL. INFO [alembic.runtime.migration] Running upgrade 18f43ac4622f -> b38c133bed3c, add created_by and created_at columns :/usr/src/app$ ``` </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
#1005
Description of Changes
This fixes the issue we were having with trying to drop the
faces_user_id_fkeyin the push tomain. What happened was thefaces_user_id_fkeywasn't saved under a name in the previous database model. PosgreSQL will drop any attached constraints when a column is dropped (presuming there are noCASCADEeffects), so I am removing thedrop_constraintcommands and JUST dropping the column. This will allow PostgreSQL to take care of the constraint problem for us.Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.DB migration output