Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create generic DB_CACHE functions for db.Model classes #1011

Merged
merged 35 commits into from
Aug 7, 2023

Conversation

michplunkett
Copy link
Collaborator

@michplunkett michplunkett commented Aug 4, 2023

Fixes issue

#997

Description of Changes

I created a cacheing file that allows us to remove values from the cache when its underlying dataset has changed for all versions of a SQLAlchemy Model.

Tests and linting

  • This branch is up-to-date with the develop branch.
  • pytest passes on my local development environment.
  • pre-commit passes on my local development environment.

@michplunkett michplunkett self-assigned this Aug 4, 2023
@michplunkett michplunkett linked an issue Aug 4, 2023 that may be closed by this pull request
@@ -87,7 +87,7 @@ def __init__(
("IVANA", "", "TINKLE"),
("SEYMOUR", "", "BUTZ"),
("HAYWOOD", "U", "CUDDLEME"),
("BEA", "", "PROBLEM"),
("BEA", "", "O'PROBLEM"),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michplunkett michplunkett changed the title Create cache singleton Create cache class Aug 4, 2023
@michplunkett michplunkett changed the title Create cache class Create cache file for key logic Aug 4, 2023
@michplunkett michplunkett marked this pull request as ready for review August 4, 2023 22:39
Copy link
Collaborator

@abandoned-prototype abandoned-prototype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any background with this caching library, but to the extent I can judge it, it looks good to me

@michplunkett michplunkett changed the title Create cache file for key logic Create generic DB_CACHE functions for db.Model classes Aug 7, 2023
@michplunkett michplunkett merged commit 32eec2c into develop Aug 7, 2023
2 checks passed
@michplunkett michplunkett deleted the cache_singleton branch August 7, 2023 17:00
sea-kelp pushed a commit to OrcaCollective/OpenOversight that referenced this pull request Sep 25, 2023
…ns#1011)

lucyparsons#997

I created a cacheing file that allows us to remove values from the cache
when its underlying dataset has changed for all versions of a
`SQLAlchemy` `Model`.

 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
sea-kelp pushed a commit to OrcaCollective/OpenOversight that referenced this pull request Sep 25, 2023
…ns#1011)

lucyparsons#997

I created a cacheing file that allows us to remove values from the cache
when its underlying dataset has changed for all versions of a
`SQLAlchemy` `Model`.

 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
sea-kelp pushed a commit to OrcaCollective/OpenOversight that referenced this pull request Oct 9, 2023
…ns#1011)

lucyparsons#997

I created a cacheing file that allows us to remove values from the cache
when its underlying dataset has changed for all versions of a
`SQLAlchemy` `Model`.

 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
AetherUnbound pushed a commit to OrcaCollective/OpenOversight that referenced this pull request Nov 11, 2023
…ns#1011)

lucyparsons#997

I created a cacheing file that allows us to remove values from the cache
when its underlying dataset has changed for all versions of a
`SQLAlchemy` `Model`.

 - [x] This branch is up-to-date with the `develop` branch.
 - [x] `pytest` passes on my local development environment.
 - [x] `pre-commit` passes on my local development environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create DB cache logic file
2 participants