Address edit Department error
#1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
commented
Aug 30, 2023
| @@ -675,7 +675,6 @@ def redirect_add_department(): | |||
| @admin_required | |||
| def add_department(): | |||
| form = DepartmentForm() | |||
| form.created_by = current_user.get_id() | |||
There was a problem hiding this comment.
This was in add_department, but it certainly doesn't belong there as the field no longer exists.
michplunkett
commented
Aug 30, 2023
Comment on lines
+529
to
+530
| assert department.created_by == user.id | ||
| assert department.last_updated_by == user.id |
There was a problem hiding this comment.
Assert both fields are populated upon creation.
michplunkett
commented
Aug 30, 2023
| @@ -692,6 +695,8 @@ def test_admin_can_edit_police_department(mockdata, client, session): | |||
| edit_state_department = Department.query.filter_by(name=CorrectedPD.name).one() | |||
| assert edit_state_department.short_name == CorrectedPD.short_name | |||
| assert edit_state_department.state == CorrectedPD.state | |||
| assert edit_state_department.last_updated_by == user.id | |||
| assert edit_state_department.last_updated_at > edit_state_department.created_at | |||
There was a problem hiding this comment.
Assert that the last_updated_at value is greater than the created_at value.
michplunkett
commented
Aug 30, 2023
michplunkett
commented
Aug 30, 2023
michplunkett
commented
Aug 30, 2023
|
Would you mind adding a test for this? I definitely would have expected one of our tests to have picked this up |
|
Which error specifically? I checked the behavior of the app manually and via tests, and couldn't find the bug. It ends up that's because it wasn't a bug in the current version, but one that was fixed in one of the last 5 PRs. |
|
Can you recheck this PR when you get a chance, @sea-kelp? |
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 9, 2023
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I removed the created_by field from the from on editing a
Department.Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.