Fix upload bug #1095
Fix upload bug #1095
Conversation
|
The failing test seems to pass locally for me once I add a S3 bucket - not sure if that's set up in the CI tests. |
| @@ -1342,7 +1338,7 @@ def leaderboard(): | |||
|
|
|||
|
|
|||
| @main.route( | |||
| "/cop_face/department/<int:department_id>/images/<int:image_id>", | |||
| "/cop_face/department/<int:department_id>/image/<int:image_id>", | |||
| def get_dept_units(department_id: int = 0): | ||
| def get_dept_units(department_id: Optional[int] = None): |
There was a problem hiding this comment.
Could you add methods for this function and the redirect one?
There was a problem hiding this comment.
app.route methods defaults to ["GET"]. Is there any reason we need to specify methods?
There was a problem hiding this comment.
I prefer minimal assumptions when possible, but it's not a deal breaker.
| flash(FLASH_MSG_PERMANENT_REDIRECT) | ||
| return redirect( | ||
| url_for("main.get_dept_ranks", department_id=department_id), | ||
| url_for("main.get_dept_units", department_id=department_id), |
|
|
||
|
|
||
| @pytest.mark.xdist_group | ||
| def test_anonymous_user_can_upload_image(mockdata, browser, server_port): |
|
It fails because file uploads are not supported in the CI tests. The other test that makes use of the upload is marked with this decorator: |
| @@ -1855,9 +1852,8 @@ def redirect_upload(department_id: int = 0, officer_id: int = 0): | |||
| "/upload/departments/<int:department_id>/officers/<int:officer_id>", | |||
| methods=[HTTPMethod.POST], | |||
| ) | |||
| @login_required | |||
There was a problem hiding this comment.
This is the line that was causing issues
|
We can deploy this tomorrow afternoon, should you be good to merge it before then. |
|
I don't seem to have merge permissions so feel free to merge when you get a chance! |
Description of Changes
Cherry-pick of OrcaCollective#434
@login_requireddecoratorNotes for Deployment
None!
Screenshots (if appropriate)
N/A
Tests and Linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.