Deploy release 0.6.1 to production #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main-> develop copy update
Previously, the list_officer.html template (/departments/:id:) would throw an error if there were any officers on the page with no assignments. Specifically, it would throw jinja2.exceptions.UndefinedError: sqlalchemy.orm.dynamic.AppenderBaseQuery object has no element 0
1) Add --update-by-name, which allows officers to be updated by name (without star_no or unique_internal_identifier) within a department. 2) Add --update-static-fields, which allows normally-static fields like race, employment date, etc. to be updated. 3) Unconditionally relaxes a check on static fields, so that if a static field is None, and an imported CSV contains data for it, it will be updated, regardless of whether --update-static-fields is passed. This seems sensible and does not break any unit tests. 4) Add --no-create, which causes bulk_add_officers to never create new officers, and only update existing ones. Any unknown officers in the imported CSV will simply be ignored. 5) Adds a mode to the get_officers() function, whereby if star_no is passed as None, get_officers() just returns the first officer with the given first and last name. (This is required for --update-by-name.)
Someday the code will be old and this comment will be superfluous.
handle auth check for when request.endpoint is None
In looking at flask-sqlalchemy's github issue about this, I realized that: a) they already pushed a fixed release b) this will affect anyone who happens to be running a 3.8.4, which shouldn't be too many people, but may be nonzero Let's just add the fix to the package, just in case. And while I'm here, let's test against 3.8 again too.
New version of flake8 has new edits wanted. Do them.
Upgrade Flask-SQLAlchemy to guard against #754
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>
…sh-4.17.19 Bump lodash from 4.17.15 to 4.17.19
Changes needed for Vermont OO
Handle officer and dept mismatch when tagging
Use Flask-Sitemap to autogenerate an XML sitemap
fixing #778 - assignment downloads
temp: disable automated production backup
The previous code path was missing a commit() in the db session that marked users as confirmed when accessing the /auth/confirm/<token> route, so add that. Fixes #762 (hopefully)
Docker was complaining about the version of nodejs we were running just because it stopped being supported in December. Upgrade to latest nodejs 12 LTS. Also, upgrade the version of node-sass we use to a version compatible with nodejs 12. No visible differences in our generated CSS, though I did not do a before/after CSS diff.
Confirm the confirmed users, allow fake email for devs
Upgrade to latest NodeJS LTS
redshiftzero
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanting to get the user activation fix out sooner than later.