Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some mypy warnings #53

Closed
wants to merge 3 commits into from
Closed

Fix some mypy warnings #53

wants to merge 3 commits into from

Conversation

KapJI
Copy link
Contributor

@KapJI KapJI commented Apr 17, 2021

Proposed change

Even though there are type hints, mypy is not run to check them. I fixed some issue but there are many more, please help me to fix them.

Also isort wasn't run in CI and it was missing configuration, added that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionalit)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass.
  • There is no commented out code in this PR.
  • The code has been formatted using Black (make black)
  • Tests have been added to verify that the new code works.

@KapJI
Copy link
Contributor Author

KapJI commented Apr 20, 2021

@ludeeus are you interested in fixing this?

@KapJI
Copy link
Contributor Author

KapJI commented Apr 27, 2021

@ludeeus ping

@ludeeus
Copy link
Owner

ludeeus commented Aug 10, 2021

Replaced by #76

@ludeeus ludeeus closed this Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants