-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable strict mypy checks #76
Conversation
@KapJI can you take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
In #53 I also added basic isort config, it might be useful to have consistent output for isort and black.
str.__init__(string) | ||
|
||
def __new__(cls, version, _=None): | ||
def __new__(cls, version: str, _: Optional[Any] = None) -> "_AwesomeVersionBase": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add from __future__ import annotation
to use unquoted type.
def __new__(cls, version: str, _: Optional[Any] = None) -> "_AwesomeVersionBase": | |
def __new__(cls, version: str, _: Optional[Any] = None) -> _AwesomeVersionBase: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from __future__ import annotation
can only be used from python 3.7, this library has support for 3.6 as well.
I did not see that, added that as well now 👍 |
Thanks for looking it over @KapJI 👍 |
Proposed change
Enable strict mypy checks
replaces #53
Type of change
Additional information
Checklist
make black
)