Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address validation error #11

Closed
keukenrol opened this issue Oct 18, 2022 · 17 comments
Closed

Address validation error #11

keukenrol opened this issue Oct 18, 2022 · 17 comments

Comments

@keukenrol
Copy link

Hi

the BME280 shows me an address validation error. NaN is not defined, despite the number being filled (0x76).

Any idea? Tried deleting the node and putting in a new one, but the issue persists.

@maga-1
Copy link
Contributor

maga-1 commented Nov 12, 2022

This is probably the same error I have fixed in this pull request: #10

@keukenrol
Copy link
Author

Ok thanks, will this new fixed version be released via npm?

@ludiazv
Copy link
Owner

ludiazv commented Nov 23, 2022

Yes I try to publish it during this week.

@keukenrol
Copy link
Author

Updated today.
Now showing error: Invalid properties: Invalid number
-> when sea pressure is not filled in
Rest works OK!

@SirReal-surreal
Copy link

SirReal-surreal commented Feb 22, 2023

Hi!
I updated to the latest node.js version (from 12 to 18) and got the same issue. As this error don't stop the code, it is still working.
However, the issue is the NaN vs. Nan typo which is fixed on 1.1.0, right? However, npm doesn't update my node to 1.1.0, it stays on 1.0.0.
I did manually edit the HTML to correct the code and it works well, now. But there is an issue with updating the node via npm.

@hasenradball
Copy link

@SirReal-surreal
Hi I have the same error....
What do I need to do?
how can I get the v 1.1.0?

@SirReal-surreal
Copy link

@SirReal-surreal Hi I have the same error.... What do I need to do? how can I get the v 1.1.0?

The update didn't work - so I edited the HTML source manually. You need to find the HTML source for the node BME280 on your raspberry and you change the "n" to a capital "N" and that's it.

The path is something like this (if default is used):
/home/pi/.node-red/node_modules/node-red-contrib-bme280
and the file is called:
bme280.html
Line 38 (in my case).

@hasenradball
Copy link

Ah for the NAN....

understood Thank you!

@hasenradball
Copy link

But I would say if the update doesn‘ t work is a big problem.

@ludiazv
Copy link
Owner

ludiazv commented Jun 1, 2023

Hi guys,
This issue is quite strange. The fix for the typo in was merged in this PR #10. And the version was published to npmjs check it out: https://www.npmjs.com/package/node-red-contrib-bme280

I just checked the package installing it from npm and the NaN issue is fixed. I doubt it the problem has any relation with the node version or npm as isNaN is std javascript function. So something fishy is going on.

I'm will be busy for the next two week. So I can't do proper test. If someone is able to test why this happening pleas let me know.

@SirReal-surreal
Copy link

SirReal-surreal commented Jun 1, 2023

Hi @ludiazv !
On my YouTube channel I got several guys facing this problem. All fixed it manually by changing the HTML on their own.
So, yes, it seems to be fixed in 1.1.0 but this update is not taken by npm. Not sure why, but somehow the released version is not seen as an update.
As this bug was not seen before on the older node.js versions, I can only assume that we all used 1.0.0 since a while but the older node.js version didn't complain about a missing capital N.

@hasenradball
Copy link

@ludiazv
@SirReal-surreal
Please look to this Ticket answer I created:
node-red/node-red#4210 (comment)

Problem should be solved.

This is because the author of the module never requested its entry on the Flow Library to be updated to the latest version.

When logged into the Flow Library there is a 'check for updates' button in the sidebar of every page. I have just clicked that button and the entry has been updated to the latest release.

The Palette Manager catalog will be updated by an automated process in the next hour.

@keukenrol
Copy link
Author

Solved over here with updater using palette.

@SirReal-surreal
Copy link

Great - I can see the update now:
image

@hasenradball
Copy link

Then I Think we can close this issue now.

@ludiazv
Copy link
Owner

ludiazv commented Jun 2, 2023

Thanks @hasenradball for solving the issue.

@ludiazv ludiazv closed this as completed Jun 2, 2023
@hasenradball
Copy link

you are welcome
😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants