Add natural sorting for tracks and filters #73
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly I'd like to say I've been looking for a music player for Linux like this one for years, so thanks for your work!
At the moment, Fooyin uses ASCII-order sorting for the library, as is also the case for most other players I've used. For a music player, I believe natural sorting should be used instead. The core argument for this goes pretty far back, but in our case, consider the current sorting of some Bach works with their commonly used Opus number:
Using
QCollator
instead, the player will use a natural sort more similar to the behavior of foobar2000:I am a C programmer by trade so there might be some bad code here.