Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with finufft v2.0.2 stable #24

Merged
merged 7 commits into from Jan 24, 2021
Merged

Compatibility with finufft v2.0.2 stable #24

merged 7 commits into from Jan 24, 2021

Conversation

jkrimmer
Copy link
Contributor

finufft_jll corresponding to stable finufft v2.0.2 is now availble as an artifact. The options struct has been adapted according to the most recent release.

@coveralls
Copy link

coveralls commented Dec 16, 2020

Pull Request Test Coverage Report for Build 151

  • 7 of 20 (35.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-11.8%) to 82.443%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/FINUFFT.jl 7 20 35.0%
Files with Coverage Reduction New Missed Lines %
src/FINUFFT.jl 6 68.79%
Totals Coverage Status
Change from base Build 148: -11.8%
Covered Lines: 108
Relevant Lines: 131

💛 - Coveralls

@jkrimmer jkrimmer marked this pull request as ready for review January 20, 2021 12:18
Project.toml Outdated Show resolved Hide resolved
Project.toml Show resolved Hide resolved
@ludvigak
Copy link
Owner

Nice work! :)

@ludvigak ludvigak merged commit 99ad0c7 into ludvigak:master Jan 24, 2021
@jkrimmer
Copy link
Contributor Author

Thanks a lot! How do you feel about having a new release so more users can benefit from the artifact-resolved binary dependency?

@ludvigak
Copy link
Owner

Absolutely, I triggered the registration just now. I was just switching the CI to GitHub actions while I was at it!

Thanks again for your work. Unfortunately I don't have time to work on maintenance that often these days, so I really appreciate it. And please don't hesitate to nag me if I don't react to a pull request ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants