Skip to content

Commit

Permalink
Add comment about batch size tuning (#3526)
Browse files Browse the repository at this point in the history
  • Loading branch information
arnavgarg1 committed Aug 11, 2023
1 parent 007c261 commit 9bf68da
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ludwig/trainers/trainer_llm.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,9 @@ def tune_batch_size(
snapshot_weights: bool = True,
on_best_batch_size_updated: Optional[Callable[[int, float, int], None]] = None,
) -> int:
# TODO: Implement batch size tuning for LLM, currently just returns the default batch size
# Compared to ECD, this just requires forward passes till we OOM.
# https://github.com/ludwig-ai/ludwig/issues/3525
return MINIMUM_BATCH_SIZE

@property
Expand Down

0 comments on commit 9bf68da

Please sign in to comment.