Merge branch 'skip_all_evaluation' of github.com:ludwig-ai/ludwig int…

…o skip_all_evaluation
ludwig-ai · Aug 23, 2023 · af3b1db · af3b1db
2 parents fdc1b24 + f40e1fc
commit af3b1db
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/ludwig/api.py b/ludwig/api.py
@@ -695,7 +695,11 @@ def on_epoch_end(self, trainer, progress_tracker, save_path):
                             save_json(training_stats_fn, train_stats)
 
                     # results of the model with highest validation test performance
-                    if self.backend.is_coordinator() and validation_set is not None and not trainer.skip_all_evaluation:
+                    if (
+                        self.backend.is_coordinator()
+                        and validation_set is not None
+                        and not self.config_obj.trainer.skip_all_evaluation
+                    ):
                         print_boxed("TRAINING REPORT")
                         training_report = get_training_report(
                             trainer.validation_field,

diff --git a/ludwig/trainers/trainer_llm.py b/ludwig/trainers/trainer_llm.py
@@ -111,7 +111,7 @@ def __init__(
         self.evaluate_training_set = self.config.evaluate_training_set
         self.skip_all_evaluation = self.config.skip_all_evaluation
 
-    def finish_training(
+    def close_writers(
         self, progress_tracker, save_path, train_summary_writer, validation_summary_writer, test_summary_writer
     ):
         # ================ Finished Training ================
@@ -174,7 +174,7 @@ def train(
         return_value = self.model if not return_state_dict else self.model.cpu().state_dict()
 
         if self.skip_all_evaluation:
-            self.finish_training(
+            self.close_writers(
                 progress_tracker, save_path, train_summary_writer, validation_summary_writer, test_summary_writer
             )
             return (
@@ -197,7 +197,7 @@ def train(
                 save_path,
             )
         finally:
-            self.finish_training(
+            self.close_writers(
                 progress_tracker, save_path, train_summary_writer, validation_summary_writer, test_summary_writer
             )