Fixes trainability of sparse embeddings (#2049)

ludwig-ai · May 23, 2022 · d58c609 · d58c609
1 parent 9590ceb
commit d58c609
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/ludwig/encoders/category_encoders.py b/ludwig/encoders/category_encoders.py
@@ -79,8 +79,7 @@ class CategoricalSparseEncoder(Encoder):
     def __init__(
         self,
         vocab: List[str],
-        embedding_size: int = 50,
-        embeddings_trainable: bool = True,
+        embeddings_trainable: bool = False,
         pretrained_embeddings: Optional[str] = None,
         embeddings_on_cpu: bool = False,
         dropout: float = 0.0,
@@ -93,7 +92,7 @@ def __init__(
         logger.debug("  Embed")
         self.embed = Embed(
             vocab=vocab,
-            embedding_size=embedding_size,
+            embedding_size=len(vocab),
             representation="sparse",
             embeddings_trainable=embeddings_trainable,
             pretrained_embeddings=pretrained_embeddings,