Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pydantic v2 #3692

Open
dragosmc opened this issue Oct 5, 2023 · 3 comments
Open

Update to pydantic v2 #3692

dragosmc opened this issue Oct 5, 2023 · 3 comments

Comments

@dragosmc
Copy link

dragosmc commented Oct 5, 2023

Is your feature request related to a problem? Please describe.
Pydantic v2 has been out for a few months now and it brings new cool features as well as big performance improvements due to its use of Rust for validation. Currently Ludwig requires Pydantic < 2.0.

The conflict is caused by:
    The user requested pydantic==2.4.2
    ludwig 0.8.4 depends on pydantic<2.0

Are there any plans to update to the new version?

I might be able to help with this.

@justinxzhao
Copy link
Collaborator

Hi @dragosmc,

We had to pin pydantic to <2.0 in #3537 because it was incompatible with transformers.

If we could get your help to check if transformers is compatible, and then releasing the pin on Ludwig, that would be great!

@dragosmc
Copy link
Author

dragosmc commented Oct 5, 2023

I see. In that case I guess we'll wait for them to update (or one of their dependencies) as they are still forcing pydantic<2 at the moment. Thanks.

@dragosmc dragosmc closed this as completed Oct 5, 2023
@dragosmc
Copy link
Author

dragosmc commented Apr 9, 2024

Hi, I'm reopening this as transformers have updated their code to use pydantic2 huggingface/transformers#27933 and it feels like ludwig could remove the version restriction.

@dragosmc dragosmc reopened this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants