Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Pin pydantic to < 2.0 #3537

Merged
merged 1 commit into from
Aug 16, 2023
Merged

[bug] Pin pydantic to < 2.0 #3537

merged 1 commit into from
Aug 16, 2023

Conversation

jeffkinnison
Copy link
Contributor

When installing Ludwig in a new env, transformers will raise the following error

RuntimeError: Failed to import transformers.modeling_utils because of the following error (look up to see its traceback):
If you use `@root_validator` with pre=False (the default) you MUST specify `skip_on_failure=True`. Note that `@root_validator` is deprecated and should be replaced with `@model_validator`.

transformers requires pydantic 1.x, however pydantic 2.x is being installed. More details can be found in this issue. This update pins pydantic to 1.x while transformers is being updated.

@arnavgarg1
Copy link
Contributor

Nice, great catch!

@jeffkinnison
Copy link
Contributor Author

Thanks to @ksbrar for surfacing this! I opened this as a test bed to see if there are any other packages that require pydantic 2.x.

@github-actions
Copy link

Unit Test Results

  6 files  +  3    6 suites  +3   1h 0m 54s ⏱️ + 9m 0s
34 tests +  4  29 ✔️ +  4    5 💤 ±0  0 ±0 
88 runs  +36  72 ✔️ +27  16 💤 +9  0 ±0 

Results for commit abf66cd. ± Comparison against base commit 756ddf5.

@jeffkinnison jeffkinnison merged commit 090918d into master Aug 16, 2023
16 checks passed
@jeffkinnison jeffkinnison deleted the pin-pydantic-1.x branch August 16, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants